Skip to content

Conversation

ItoroD
Copy link
Collaborator

@ItoroD ItoroD commented Oct 6, 2025

This PR address #25

@ItoroD ItoroD requested a review from thunderbiscuit as a code owner October 6, 2025 21:46
@ItoroD ItoroD force-pushed the fix-kyoto-example-2 branch from a1afe77 to 74997e9 Compare October 7, 2025 22:28
@ItoroD
Copy link
Collaborator Author

ItoroD commented Oct 7, 2025

Moved module update to its own commit

Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting the submodule update into its own commit, that was going to be one of my review comments.

My last thing would be that I'd like to add the short commit hash on the submodule to the commit message, because it's really hard to find when reviewing or looking at the commit history. I can git clone and see it by doing git submodule status, but it's easier if it's right in the message IMO.

@ItoroD ItoroD force-pushed the fix-kyoto-example-2 branch from 74997e9 to 4f4105a Compare October 8, 2025 18:09
@ItoroD
Copy link
Collaborator Author

ItoroD commented Oct 8, 2025

I hope this is what you mean

@thunderbiscuit
Copy link
Member

Yep that's good!

@thunderbiscuit thunderbiscuit merged commit 4f4105a into bitcoindevkit:master Oct 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants